qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/55] block: Make BlockDriver method bdrv_eject


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH 08/55] block: Make BlockDriver method bdrv_eject() return void
Date: Fri, 22 Jul 2011 16:41:26 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc15 Thunderbird/3.1.11

Am 20.07.2011 18:23, schrieb Markus Armbruster:
> Callees always return 0, except for FreeBSD's cdrom_eject(), which
> returns -ENOTSUP when the device is in a terminally wedged state.
> 
> The only caller is bdrv_eject(), and it maps -ENOTSUP to 0 since
> commit 4be9762a.
> 
> Signed-off-by: Markus Armbruster <address@hidden>

What about failed ioctls? Currently we only print an error message but
still return 0. Is this the right behaviour? Could callers make use of
an error return here or would we end up like with bdrv_set_locked()
where we can't really communicate the error to the guest?

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]