[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/55] ide: Update command code definitions as p
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 10/55] ide: Update command code definitions as per ACS-2 Table B.2 |
|
Date: |
Mon, 25 Jul 2011 19:15:18 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Christoph Hellwig <address@hidden> writes:
> On Wed, Jul 20, 2011 at 06:23:44PM +0200, Markus Armbruster wrote:
>> Drop WIN_SRST, it has same value as WIN_DEVICE_RESET.
>>
>> CFA_IDLEIMMEDIATE isn't specific to CFATA. ACS-2 shows it as a
>> defined command in ATA-1, -2 and -3. Rename to WIN_IDLEIMMEDIATE2.
>>
>> Turn unused macros into comments.
>
> I don't think that part is overly helpful. In general you'd want to
> keep all defines for protocol headers, just to make it easier to
> actually use them later on.
Which ones to keep? Just non-obsolete ones? According to which version
of the standard?
- [Qemu-devel] [PATCH 23/55] block: Show whether the guest ejected the medium in info block, (continued)
[Qemu-devel] [PATCH 26/55] scsi-disk: Track tray locked state, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 14/55] ide: Reject ATA commands specific to drive kinds, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 10/55] ide: Update command code definitions as per ACS-2 Table B.2, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 07/55] block: Make BlockDriver method bdrv_set_locked() return void, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray state mismatch, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 03/55] block: Attach non-qdev devices as well, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 11/55] ide: Clean up case label indentation in ide_exec_cmd(), Markus Armbruster, 2011/07/20