[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/6] pseries: interrupt controller should not have a
From: |
David Gibson |
Subject: |
[Qemu-devel] [PATCH 5/6] pseries: interrupt controller should not have a 'reg' property |
Date: |
Thu, 4 Aug 2011 17:02:18 +1000 |
The interrupt controller presented in the device tree for the pseries
machine is manipulated by the guest only through hypervisor calls. It
has no real or emulated registers for the guest to access.
However, it currently has a bogus 'reg' property advertising a register
window. Moreover, this property has an invalid format, being a 32-bit
zero, when the #address-cells property on the root bus indicates that it
needs a 64-bit address. Since the guest never attempts to manipulate
the node directly, it works, but it is ugly and can cause warnings when
manipulating the device tree in other tools (such as future firmware
versions).
This patch, therefore, corrects the problem by entirely removing the
interrupt-controller node's 'reg' property.
Signed-off-by: David Gibson <address@hidden>
---
hw/spapr.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/spapr.c b/hw/spapr.c
index bc15b5c..cf9f758 100644
--- a/hw/spapr.c
+++ b/hw/spapr.c
@@ -191,12 +191,11 @@ static void *spapr_create_fdt_skel(const char *cpu_model,
_FDT((fdt_end_node(fdt)));
/* interrupt controller */
- _FDT((fdt_begin_node(fdt, "address@hidden")));
+ _FDT((fdt_begin_node(fdt, "interrupt-controller")));
_FDT((fdt_property_string(fdt, "device_type",
"PowerPC-External-Interrupt-Presentation")));
_FDT((fdt_property_string(fdt, "compatible", "IBM,ppc-xicp")));
- _FDT((fdt_property_cell(fdt, "reg", 0)));
_FDT((fdt_property(fdt, "interrupt-controller", NULL, 0)));
_FDT((fdt_property(fdt, "ibm,interrupt-server-ranges",
interrupt_server_ranges_prop,
--
1.7.5.4
- [Qemu-devel] pseries machine updates, David Gibson, 2011/08/04
- [Qemu-devel] [PATCH 4/6] pseries: Add a phandle to the xicp interrupt controller device tree node, David Gibson, 2011/08/04
- [Qemu-devel] [PATCH 5/6] pseries: interrupt controller should not have a 'reg' property,
David Gibson <=
- [Qemu-devel] [PATCH 6/6] pseries: More complete WIMG validation in H_ENTER code, David Gibson, 2011/08/04
- [Qemu-devel] [PATCH 3/6] pseries: Add real mode debugging hcalls, David Gibson, 2011/08/04
- [Qemu-devel] [PATCH 2/6] Implement POWER7's CFAR in TCG, David Gibson, 2011/08/04
- [Qemu-devel] [PATCH 1/6] pseries: Bugfixes for interrupt numbering in XICS code, David Gibson, 2011/08/04
- Re: [Qemu-devel] pseries machine updates, Alexander Graf, 2011/08/10