qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 01/12] char: rename qemu_chr_write() to qemu_chr_fe_write()
Date: Thu, 04 Aug 2011 19:00:48 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc15 Thunderbird/3.1.11

On 08/01/2011 05:22 PM, Anthony Liguori wrote:
The char layer is confusing.  There is a front-end, typically a device, that
can send and receive data.  The front-end sends data by calling
qemu_chr_write().

The back-end, typically created via -chardev, can also send and receive data.
Oddly, it sends data by calling qemu_chr_read().

Let's be explicit about which function is for which party.

A different way to accomplish this would be to have each pipe expose two interfaces (a front end and a back end), and use the same functions for both. Just like a unix pipe.

The back end interface would typically be an internal object.

--
error compiling committee.c: too many arguments to function




reply via email to

[Prev in Thread] Current Thread [Next in Thread]