|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init |
Date: | Mon, 08 Aug 2011 07:45:19 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10 |
On 08/08/2011 05:36 AM, Michael S. Tsirkin wrote:
Thinking more closely, I don't think this right. Updating on map ensured that the config was refreshed after each time the bar was mapped. In the very least, the config needs to be refreshed during reset because the guest may write to the guest space which should get cleared after reset. Regards, Anthony LiguoriNot sure I understand. Which register, for example, do you have in mind? Could you clarify please?
Actually, you never need to call config_get() AFAICT. It's called in every read/write access. So I think the code you changed is extraneous now.
Regards, Anthony Liguori
} static int virtio_blk_init_pci(PCIDevice *pci_dev)
[Prev in Thread] | Current Thread | [Next in Thread] |