qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Disable guest_agent for mingw32


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] configure: Disable guest_agent for mingw32
Date: Mon, 08 Aug 2011 14:17:38 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 08/06/2011 03:47 PM, Stefan Weil wrote:
guest_agent is not supported for mingw32, so the default value
should be 'no', not 'yes'.

This removes the dependencies to glib-2.0 and python which
makes native and cross builds for w32 much easier (no need
to get and install these extra packages).

It also avoids the problems caused by different bitfield alignment
which is required by glib-2.0.

It is still possible to set guest_agent=yes via configure option.

Signed-off-by: Stefan Weil<address@hidden>

This came in too late to make 0.15.0. I'd consider applying this to the stable branch but I'd really prefer we fix the slirp packing issue directly.

Regards,

Anthony Liguori

---
  configure |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/configure b/configure
index 0c67a4a..4cb33d9 100755
--- a/configure
+++ b/configure
@@ -493,6 +493,7 @@ if test "$mingw32" = "yes" ; then
    bindir="\${prefix}"
    sysconfdir="\${prefix}"
    confsuffix=""
+  guest_agent="no"
  fi

  werror=""




reply via email to

[Prev in Thread] Current Thread [Next in Thread]