Re: [Qemu-devel] sparc32_dma: correctly initialize ledma base address

[Mark Cave-Ayland]

On 11/08/11 17:11, Bob Breuer wrote:

> The ledma base address defaults to 0xff000000 on reset.  This
> fixes a bug with Solaris and SS-20 OBP when boot net is skipped.
>
> Signed-off-by: Bob Breuer<address@hidden>
> ---
>
> diff --git a/hw/sparc32_dma.c b/hw/sparc32_dma.c
> index e75694b..61812fb 100644
> --- a/hw/sparc32_dma.c
> +++ b/hw/sparc32_dma.c
> @@ -252,6 +252,9 @@ static void dma_reset(DeviceState *d)
>
>       memset(s->dmaregs, 0, DMA_SIZE);
>       s->dmaregs[0] = DMA_VER;
> +    if (s->is_ledma) {
> +        s->dmaregs[3] = 0xff000000;
> +    }
>   }
>
>   static const VMStateDescription vmstate_dma = {

Oh that's interesting indeed. This corresponds to the fix I added to 
OpenBIOS here: 
http://lists.openbios.org/pipermail/openbios/2011-April/006350.html.

I guess that we should just assume a fixed address of 0xff000000 based 
upon the evidence we have to date.


ATB,

Mark.

--
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063

Sirius Labs: http://www.siriusit.co.uk/labs