[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Rename dma.c and its contents to reflect its IS
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH] Rename dma.c and its contents to reflect its ISA specific nature |
Date: |
Tue, 16 Aug 2011 10:32:55 +0400 (MSD) |
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Tue, 16 Aug 2011, David Gibson wrote:
> On Mon, Aug 15, 2011 at 11:39:29AM +0400, malc wrote:
> > On Mon, 15 Aug 2011, David Gibson wrote:
> >
> > > hw/dma.c does not contain code generally relevant to drivers accessing
> > > system memory. In particular, it has no connection to dma.h, which does
> > > have headers pertaining to the generally useful dma functions in
> > > dma-helpers.c. Rather, it is code specific to emulating the legacy
> > > ISA-style DMA controllers found on some platforms.
> > >
> > > To address this misleading naming, this function renames hw/dma.c to
> > > hw/isa-dma.c, and renames exported functions within it as s/DMA/isa_dma/.
> > > Makefiles and configure script are updated accordingly.
> > >
> >
> > It has been done before btw:
> > http://repo.or.cz/w/qemu/malc.git/shortlog/refs/heads/redma1
> > http://repo.or.cz/w/qemu/malc.git/shortlog/refs/heads/redma
> >
> > With a slightly more consistent naming (i8257_ instead of isa_dma_)
> > Not that i object to this.
>
> Ok, so, was there a reason that patch didn't go in at the time?
>
I don't remember, maybe Herve does.
--
mailto:address@hidden