qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful
Date: Wed, 24 Aug 2011 16:06:38 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

On 08/24/2011 04:02 PM, Anthony Liguori wrote:
Too subtle, IMO. I understand that we want to avoid a full qmp parser
for one-off unit tests, but using bit fields in the exit code?

Perhaps a python script that launches qemu with qmp and -no-shutdown,
listens for the guest shutdown event, and prints out the result? That
can be easily reused in test scripts.


How can the test pass data via shutdown? You would need a scratch register of some form I think...

I meant using the port in the patch. Just replace exit() with the ordinary shutdown path - notifications, and not exiting if -no-shutdown is requested.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]