Re: [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data

[Alexander Graf]

On 24.08.2011, at 21:23, David Gibson wrote:

> On Wed, Aug 24, 2011 at 04:41:34PM -0500, Alexander Graf wrote:
>> 
>> On 24.08.2011, at 10:28, Paolo Bonzini wrote:
>> 
>>> I introduced this bug in commit 05751d3 (vscsi: always use get_sense,
>>> 2011-08-03) because at the time there was no way to expose a sense
>>> condition to SLOF and Linux manages to work around the bug.  However,
>>> the bug becomes evident now that SCSI devices also report unit
>>> attention on reset.
>>> 
>>> SLOF also has problems dealing with unit attention conditions, so
>>> it still will not boot even with this fix (just like OpenBIOS).
>>> IBM folks are aware of their part of the bug. :-)
>> 
>> David, please ack.
> 
> Done.
> 
> We also need to get the updated SLOF into place, I can't remember how
> we sent commits involving binary blobs previously.

git-format-patch should spit out a git binary diff just fine :)


Alex