Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields

[Jan Kiszka]

On 2011-08-25 15:06, Anthony Liguori wrote:
> On 08/25/2011 07:38 AM, Jan Kiszka wrote:
>> On 2011-08-25 14:02, TeLeMan wrote:
>>> On Thu, Aug 25, 2011 at 19:04, Jan Kiszka<address@hidden>  wrote:
>>>> What a mess. Do we really have to go through all 257 packed data
>>>> structs
>>>> in QEMU and add these MS compat bits to all potentially affected ones?
>>> I prefer to detect -mms-bitfields and remove it in configure.
>>
>> /me too - if that is possible, ie. if the glib bits we are using doesn't
>> require us to apply that mode. Can anyone comment on this?
> 
> So why can't we just #pragma guard all of the slirp bits?  Why are we
> doing it on a per data structure basis?

Packing all structs is not really a good idea, more a last resort.

Jan

signature.asc
Description: OpenPGP digital signature