[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui: avoid use of deprecated gnutls_*_set_priori
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] ui: avoid use of deprecated gnutls_*_set_priority functions |
Date: |
Thu, 25 Aug 2011 14:13:58 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Aug 25, 2011 at 01:27:00PM +0100, Peter Maydell wrote:
> On 25 August 2011 13:11, Stefan Hajnoczi <address@hidden> wrote:
> > From: Raghavendra D Prabhu <address@hidden>
> >
> > The gnutls_*_set_priority family of functions has been marked deprecated
> > in 2.12.x. These functions have been superceded by
> > gnutls_priority_set_direct().
>
> Does this constitute a change in the required version of gnutls which
> we need to document in the proto-changelog for the next release?
> Is it worth updating the configure tls check to check for this function
> so we fall back to no-tls if the system version is too old?
The gnutls_priority_set_direct() function has existed since 2.1.7 according
to the GNUTLS NEWS files.
Our configure check merely looks for 'gnutls.h' which will match any
gnutls 1.x or 2.x release, and I can currently build qemu with TLS
support on a RHEL-5 host which has gnutls 1.4.1
So I believe this change will significantly increase our min required
gnutls version. We could #ifdef the code to deal with this, or perhaps
do a patch based on use of gnutls_set_default_priority() which I
believe is available in both 1.x and 2.x and is not deprecated
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|