[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields |
Date: |
Thu, 25 Aug 2011 15:19:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-08-25 15:15, Avi Kivity wrote:
> On 08/25/2011 04:07 PM, Anthony Liguori wrote:
>> On 08/25/2011 08:02 AM, Avi Kivity wrote:
>>> On 08/25/2011 03:38 PM, Jan Kiszka wrote:
>>>> >>
>>>> >> What a mess. Do we really have to go through all 257 packed data
>>>> structs
>>>> >> in QEMU and add these MS compat bits to all potentially affected
>>>> ones?
>>>> > I prefer to detect -mms-bitfields and remove it in configure.
>>>
>>> Can use -mno-ms-bitfields later to override it.
>>
>> No, we can't do that.
>>
>> The reason glib uses -mms-bitfields is that you need to use it in
>> order to call Windows APIs which is does. We will eventually need to
>> do it anyway.
>
> I meant, just for our own objects. As long as there are no glib APIs
> which use bitfields, it should work.
>
> However, I don't like it either, and prefer the
> __attribute__(((((((gcc_fields)))))) as well.
Could someone with a Windows environment test if that (or (packed,
gcc_fields)?) makes
struct {
unsigned char a;
unsigned int b;
};
truly packed again?
Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, (continued)
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Jan Kiszka, 2011/08/24
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, TeLeMan, 2011/08/24
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Jan Kiszka, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, TeLeMan, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Jan Kiszka, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Anthony Liguori, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Jan Kiszka, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields,
Jan Kiszka <=
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Anthony Liguori, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Jan Kiszka, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Peter Maydell, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Avi Kivity, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Anthony Liguori, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Jan Kiszka, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Stefan Weil, 2011/08/25
- Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields, Anthony Liguori, 2011/08/25