Re: [Qemu-devel] [PATCH] pci: add standard bridge device

[Michael S. Tsirkin]

On Thu, Aug 18, 2011 at 11:22:31AM +0800, Wen Congyang wrote:
> >From 3ce0000e5a14f0ff7aeac148f9416eac6fa7c6ca Mon Sep 17 00:00:00 2001
> From: Wen Congyang <address@hidden>
> Date: Thu, 18 Aug 2011 09:33:19 +0800
> Subject: [PATCH] PCI_Bridge: use parent bus's address space
> 
> The pci device may call pci_register_bar() to use PCI bus's address space.
> But we forget to init PCI bus's address space if it is not bus 0. It will
> cause qemu crashed.
> 
> Signed-off-by: Wen Congyang <address@hidden>

I've applied this for now so we can make progress.

> ---
>  hw/pci_bridge.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/pci_bridge.c b/hw/pci_bridge.c
> index 464d897..df16faa 100644
> --- a/hw/pci_bridge.c
> +++ b/hw/pci_bridge.c
> @@ -246,6 +246,8 @@ int pci_bridge_initfn(PCIDevice *dev)
>                          br->bus_name);
>      sec_bus->parent_dev = dev;
>      sec_bus->map_irq = br->map_irq;
> +    sec_bus->address_space_mem = parent->address_space_mem;
> +    sec_bus->address_space_io = parent->address_space_io;
>  
>      QLIST_INIT(&sec_bus->child);
>      QLIST_INSERT_HEAD(&parent->child, sec_bus, sibling);
> -- 
> 1.7.1