[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] Add support for r6040 NIC |
Date: |
Wed, 31 Aug 2011 18:30:22 +0000 |
On Wed, Aug 31, 2011 at 4:06 PM, Anthony Liguori <address@hidden> wrote:
> On 08/31/2011 09:35 AM, malc wrote:
>>
>> On Wed, 31 Aug 2011, Anthony Liguori wrote:
>>
>>> Upper case field names are not okay. If you think coding style isn't
>>> clear,
>>> that's a bug in coding style.
>>
>> Sez hu? Coding style is garbage that should be thrown out of the window.
>> As for looking, yeah, i'm looking at usb with it's lovely hungarian
>> fields, should we stampede to "fix" it?
>>
>> If the one who's going to maintain the code is fine with whatever naming
>> is used so be it.
>
> No. That's how we got into the coding style mess we're in in the first
> place.
>
> There's no benefit to going through and changing existing code but new code
> needs to be consistent with the vast majority of code in the rest of the
> tree. It's about overall code base consistency and maintainability.
I agree about importance of consistency, though I'd even go further
and reformat globally. New code gets introduced based on copying old
code so the pain goes on.
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, (continued)
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Edgar E. Iglesias, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Anthony Liguori, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Edgar E. Iglesias, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Edgar E. Iglesias, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Anthony Liguori, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Blue Swirl, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Blue Swirl, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, Edgar E. Iglesias, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, bifferos, 2011/08/31
- Re: [Qemu-devel] [PATCH] Add support for r6040 NIC, bifferos, 2011/08/31
- [Qemu-devel] [PATCH v2] Add support for r6040 NIC, bifferos, 2011/08/31