Re: [Qemu-devel] [PATCH] build: sort objects to remove duplicates for link

[Stefan Hajnoczi]

2011/9/1 Michael Roth <address@hidden>:
> On 09/01/2011 01:54 PM, Anthony Liguori wrote:
>>
>> On 08/25/2011 03:18 AM, Stefan Hajnoczi wrote:
>>>
>>> Avoid duplicate object files during the link. There are legitimate
>>> cases where a link command-line would include duplicate object files
>>> because two independent subsystems both depend on common infrastructure.
>>>
>>> Use GNU make's $(sort) function to remove duplicate object files from
>>> the link command-line.
>>>
>>> Signed-off-by: Stefan Hajnoczi<address@hidden>
>>
>> Applied. Thanks.
>>
>
> Don't think it'll hurt to have both, but "[PATCH 01/15] build: Fix linkage
> of QEMU_PROG" from Stefan's tracing pull request has the more elegant fix
> for this.

Agreed, it doesn't hurt to take this one but the $^ fix is nicer and
already merged.

Anthony: Do you want to revert this patch?  It's not necessary.

Stefan