Re: [Qemu-devel] [FIX] X86 CPU topology broken in KVM mode

[Jan Kiszka]

On 2011-09-07 10:19, Bharata B Rao wrote:
> On Wed, Sep 7, 2011 at 1:37 PM, Jan Kiszka <address@hidden> wrote:
>> On 2011-09-07 06:21, Bharata B Rao wrote:
>>> - I am not sure what is the problem with i486 as I haven't been able
>>> to boot an i486 VM successfully, hence haven't attempted to fix this.
>>
>> -smp 2 -cpu i486 boots fine here (granted, I don't have some i486 SMP
>> kernel at hand).
> 
> I am getting "Unable to find x86 CPU definition" error with -cpu i486.
> Need to investigate more.

Err, sorry: -cpu 486

> 
>>> +
>>> +    if (env->cpuid_features & CPUID_APIC) {
>>
>> || smp_cpus > 1
>>
>> Should be obvious when looking at the hunk you took this from.
> 
> Yes, but I thought no harm in initializing it for uni processor case too, no ?

486 CPUs do not have the CPUID_APIC feature set as they do not include a
local APIC. But those SMP systems have external APICs.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux