[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH 28/58] device tree: give dt more size
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH 28/58] device tree: give dt more size |
Date: |
Thu, 15 Sep 2011 09:37:48 +0200 |
On 15.09.2011, at 05:19, David Gibson wrote:
> On Wed, Sep 14, 2011 at 10:42:52AM +0200, Alexander Graf wrote:
>> We currently load a device tree blob and then just take its size x2 to
>> account for modifications we do inside. While this is nice and great,
>> it fails when we have a small device tree as blob and lots of nodes added
>> in machine init code.
>>
>> So for now, just make it 20k bigger than it was before. We maybe want to
>> be more clever about this later.
>
> In fact, one of the few things I can think of that might justify
> qemu's "abstraction" of the libfdt interface, is that the wrappers
> could be modified to detect -FDT_ERR_NOSPACE and realloc()
> appropriately.
Oh, yeah, that sounds like a very good idea!
> Otherwise the wrappers, which are limited and not notably simpler to
> use than the raw libfdt functions seem pretty pointless to me.
>
> Not that I'm biased as the author of libfdt or anything :).
I agree that the wrappers are not all that overly useful atm. I was actually
very close to just ripping them out completely instead of extending them for
new functionality. I did have the feeling that wrapping libfdt would give us a
few benefits, maybe even the chance of getting rid of #ifdefs in target code.
Could you please put this on your todo list? We should probably force every
target code in QEMU to only use the wrappers and dynamically realloc() in them.
Alex
- [Qemu-devel] [PATCH 46/58] ppc: booke206: use MAV=2.0 TSIZE definition, fix 4G pages, (continued)
- [Qemu-devel] [PATCH 46/58] ppc: booke206: use MAV=2.0 TSIZE definition, fix 4G pages, Alexander Graf, 2011/09/14
- [Qemu-devel] [PATCH 23/58] PPC: E500: Remove unneeded CPU nodes, Alexander Graf, 2011/09/14
- [Qemu-devel] [PATCH 13/58] PPC: E500: Generate IRQ lines for many CPUs, Alexander Graf, 2011/09/14
- [Qemu-devel] [PATCH 10/58] PPC: MPIC: Fix CI bit definitions, Alexander Graf, 2011/09/14
- [Qemu-devel] [PATCH 07/58] PPC: Fix IPI support in MPIC, Alexander Graf, 2011/09/14
- [Qemu-devel] [PATCH 31/58] PPC: E500: Bump CPU count to 15, Alexander Graf, 2011/09/14
- [Qemu-devel] [PATCH 25/58] PPC: E500: Update cpu-release-addr property in cpu nodes, Alexander Graf, 2011/09/14
- [Qemu-devel] [PATCH 27/58] device tree: dont fail operations, Alexander Graf, 2011/09/14
- [Qemu-devel] [PATCH 28/58] device tree: give dt more size, Alexander Graf, 2011/09/14
[Qemu-devel] [PATCH 35/58] PPC: SPAPR: Use KVM function for time info, Alexander Graf, 2011/09/14
[Qemu-devel] [PATCH 14/58] device tree: add nop_node, Alexander Graf, 2011/09/14
[Qemu-devel] [PATCH 38/58] pseries: interrupt controller should not have a 'reg' property, Alexander Graf, 2011/09/14
[Qemu-devel] [PATCH 49/58] vscsi: send the CHECK_CONDITION status down together with autosense data, Alexander Graf, 2011/09/14
[Qemu-devel] [PATCH 20/58] PPC: KVM: Remove kvmppc_read_host_property, Alexander Graf, 2011/09/14