Re: [Qemu-devel] [PATCH 1/2] KVM: emulate lapic tsc deadline timer for guest

[Marcelo Tosatti]

On Thu, Sep 15, 2011 at 02:22:58PM +0800, Liu, Jinsong wrote:
> Marcelo Tosatti wrote:
> >> diff --git a/arch/x86/include/asm/apicdef.h
> >> b/arch/x86/include/asm/apicdef.h 
> >> index 34595d5..3925d80 100644
> >> --- a/arch/x86/include/asm/apicdef.h
> >> +++ b/arch/x86/include/asm/apicdef.h
> >> @@ -100,7 +100,9 @@
> >>  #define           APIC_TIMER_BASE_CLKIN           0x0
> >>  #define           APIC_TIMER_BASE_TMBASE          0x1
> >>  #define           APIC_TIMER_BASE_DIV             0x2
> >> +#define           APIC_LVT_TIMER_ONESHOT          (0 << 17)
> >>  #define           APIC_LVT_TIMER_PERIODIC         (1 << 17)
> >> +#define           APIC_LVT_TIMER_TSCDEADLINE      (2 << 17)
> >>  #define           APIC_LVT_MASKED                 (1 << 16)
> >>  #define           APIC_LVT_LEVEL_TRIGGER          (1 << 15)
> >>  #define           APIC_LVT_REMOTE_IRR             (1 << 14)
> > 
> > Please have a separate, introductory patch for definitions that are
> > not KVM specific.
> > 
> 
> OK, will present a separate patch. BTW, will the separate patch still be send 
> to address@hidden

Yes.

> 
> >> +++ b/arch/x86/include/asm/kvm_host.h
> >> @@ -671,6 +671,8 @@ u8 kvm_get_guest_memory_type(struct kvm_vcpu
> >> *vcpu, gfn_t gfn); 
> >> 
> >>  extern bool tdp_enabled;
> >> 
> >> +extern u64 vcpu_tsc_khz(struct kvm_vcpu *vcpu);
> >> +
> > 
> > No need for extern.
> > 
> 
> Any special concern, or, for coding style? a little curious :)

It is not necessary.