Re: [Qemu-devel] [PATCH 8/8] ppc: Support tcg interpreter on ppc hosts

[Peter Maydell]

On 17 September 2011 21:00, Stefan Weil <address@hidden> wrote:
> Tests of the tcg interpreter on an (emulated) ppc host
> needed this small change.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  cache-utils.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cache-utils.h b/cache-utils.h
> index 0b65907..7c3b282 100644
> --- a/cache-utils.h
> +++ b/cache-utils.h
> @@ -1,7 +1,7 @@
>  #ifndef QEMU_CACHE_UTILS_H
>  #define QEMU_CACHE_UTILS_H
>
> -#if defined(_ARCH_PPC)
> +#if defined(_ARCH_PPC) && !defined(CONFIG_TCG_INTERPRETER)
>  struct qemu_cache_conf {
>     unsigned long dcache_bsize;
>     unsigned long icache_bsize;

This looks a bit odd, but I think that's partly an effect of
only the PPC flush_icache_range being in this header file when
for other architectures it is in tcg/*/tcg-target.h. If we
could have the cache flushing be in tcg/* for every target then
you wouldn't need to do an ifdef here.

-- PMM