[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] isapc: give system address space when pci is di
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled |
Date: |
Tue, 20 Sep 2011 10:27:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-09-19 20:49, Hervé Poussineau wrote:
> Jan Kiszka a écrit :
>> On 2011-09-18 18:04, Hervé Poussineau wrote:
>>> Signed-off-by: Hervé Poussineau <address@hidden>
>>> ---
>>> hw/pc_piix.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>>> index da6fa55..c0b8a3a 100644
>>> --- a/hw/pc_piix.c
>>> +++ b/hw/pc_piix.c
>>> @@ -121,7 +121,7 @@ static void pc_init1(MemoryRegion *system_memory,
>>> pc_memory_init(system_memory,
>>> kernel_filename, kernel_cmdline, initrd_filename,
>>> below_4g_mem_size, above_4g_mem_size,
>>> - pci_memory, &ram_memory);
>>> + pci_enabled ? pci_memory : system_memory,
>>> &ram_memory);
>>> }
>>>
>>> if (!xen_enabled()) {
>>
>> Makes sense. I guess we should rename 'pci_memory' inside pc_memory_init
>> to reflect this - 'rom_memory'?
>>
>> But -M isapc still only gives me a black screen. Are there further fixes
>> required?
>>
>
> Yes, you also need to rollback pc-bios/bios.bin to previous version (ie
> 8b06c62ae48b67b320f7420dcd4854c5559e1532)
Did you already try to bisect that probable regression in SeaBIOS?
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
Re: [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled, Anthony Liguori, 2011/09/23