qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/6] Enable joinable POSIX threads


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 1/6] Enable joinable POSIX threads
Date: Wed, 21 Sep 2011 15:38:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 09/21/2011 03:40 PM, Kevin Wolf wrote:
>
>  I think these two should be joinable.  Otherwise, you might be
>  destroying the apdu_thread_quit_mutex while the handle_apdu_thread
>  hasn't yet finished unlocking it (even though it already progressed
>  enough in qemu_mutex_destroy to release the main thread).
>
>  Anyhow, the bug is not introduced by your patch, so
>
>  Reviewed-by: Paolo Bonzini<address@hidden>
Actually, the man page says that joinable is the default, so this patch
does change the behaviour.

Yes, but it doesn't change the fact that mutexes are destroyed under the thread's feet. i.e. it doesn't introduce the race.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]