|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers |
Date: | Wed, 28 Sep 2011 08:19:06 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
On 09/28/2011 07:33 AM, Jan Kiszka wrote: >> I don't particularly care for the 3 different opcodes. Perhaps >> we'd be better off with an inline predicate for when the deposit >> opcode is "valid"? > > We still need to dispatch at tcg generation time which variant is valid. Or > what do you have in mind? Yes, but we'd know at tcg generation time that it *does* fit one of the few patterns you point out. The predicate would be used in e.g. tcg_gen_deposit_i32 to select either INDEX_op_deposit_i32 or the and/shift/and/or fallback. r~
[Prev in Thread] | Current Thread | [Next in Thread] |