|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code |
Date: | Mon, 03 Oct 2011 23:10:20 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20110818 Iceowl/1.0b1 Icedove/3.0.11 |
Am 03.10.2011 22:52, schrieb Scott Wood:
On 10/03/2011 03:43 PM, Stefan Weil wrote:qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets to initialize the cache before flush_icache_range() is called. This patch moves the code to tcg/ppc and tcg/ppc64. Initialisation is called from tcg_target_init() there. Signed-off-by: Stefan Weil <address@hidden>This is not only needed for TCG. We need flush_icache_range() for KVM. See http://patchwork.ozlabs.org/patch/90403/ and the thread starting with http://lists.gnu.org/archive/html/qemu-ppc/2011-09/msg00180.html And must this be duplicated between ppc and ppc64? -Scott
Your patch 90403 is obviously still missing in QEMU master - that's the reason why I did not notice that PPC KVM needs flush_icache_range(). qemu_cache_utils_init() should be called from kvm_init() and tcg_init() or some function called there, and cache-utils.o only generated for ppc hosts. As I don't have a ppc host, it would be better if you or Alex could provide a working patch. Thanks, Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |