|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] build errors on s390 tcg |
Date: | Tue, 04 Oct 2011 18:41:15 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110921 Thunderbird/3.1.15 |
Am 04.10.2011 14:44, schrieb Peter Maydell:
On 4 October 2011 13:23, Alexander Graf <address@hidden> wrote:The problem is that tcg.c defines the functions with int arguments for TCG register indexes, while s390/tcg-target.c takes TCGReg parameters. I'm notsure which way is better, but using TCGReg feels more type safe to me.You're not consistent, though; for example the s390 tcg_target_reg_alloc_orderarray is declared as int[], not TCGReg[]. -- PMM
I did not notice that s390 was different when I wrote my patch, but I agree with Alex that TCGReg is more type safe. I also think that using TCGReg documents the meaning of a parameter better than using a simple int. So there are two tasks to be done: - Look for inconsistencies and fix them. - Add and use TCGReg for all other targets, too. Or are there any reasons why we should keep the int type parameters? Regards, Stefan Weil
[Prev in Thread] | Current Thread | [Next in Thread] |