qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tcg: Introduce TCGReg for all TCG hosts (fixes


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH] tcg: Introduce TCGReg for all TCG hosts (fixes build for s390 hosts)
Date: Fri, 07 Oct 2011 11:13:07 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0

On 10/07/2011 11:00 AM, Stefan Weil wrote:
> +#define TCGReg int /* TODO: Remove this line when tcg-target.c uses TCGReg. 
> */

Nack.  This is too ugly to live.

How hard can it be to simply change the prototype in each
of the backend files instead?  Yes, full conversion to
TCGReg is desirable, but this is not C++ -- integers and
enums are interchangable without casts.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]