[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] rsqrte_f32: No need to copy sign bit.
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] rsqrte_f32: No need to copy sign bit. |
|
Date: |
Sat, 8 Oct 2011 23:57:11 +0100 |
On 3 October 2011 15:28, Christophe Lyon <address@hidden> wrote:
> Indeed, the result is known to be always positive.
> - val = ((val64 >> 63) & 0x80000000)
> - | ((result_exp & 0xff) << 23)
> + val = ((result_exp & 0xff) << 23)
> | ((val64 >> 29) & 0x7fffff);
> return make_float32(val);
So we weren't generating incorrect results, we were just doing
slightly more work than we really needed, right? I'm curious
what prompted this patch :-)
-- PMM