[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Build bug in virtio-9p-handle.c
From: |
David Gibson |
Subject: |
[Qemu-devel] Build bug in virtio-9p-handle.c |
Date: |
Tue, 11 Oct 2011 15:20:54 +1100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
virtio-9p-handle.c relies on a "struct file_handle". From the code it
appears that this is defined in sufficiently recent glibc versions.
Specifically, the file defines the structure itself if built on a
glibc version < 2.14.
However, this test does not appear to be correct. Fedora 16, for
example, currently has packaged libc 2.14.90 which does _not_ contain
the struct file_handle definition. This means that qemu will not
compile there, without hacking the #if.
I don't know if struct file_handle was added partway through the 2.14
series and the test needs refinement, or if the test is just plain
wrong, but one way or another, it needs a fix.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] Build bug in virtio-9p-handle.c,
David Gibson <=