[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/10] scsi-generic: check ioctl statuses when SG_IO
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 03/10] scsi-generic: check ioctl statuses when SG_IO succeeds |
Date: |
Wed, 12 Oct 2011 16:24:04 +0200 |
A succeeding ioctl does not imply that the SCSI command succeeded.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi-generic.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 5130e9a..04549aa 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -311,7 +311,7 @@ static int get_blocksize(BlockDriverState *bdrv)
io_header.timeout = 6000; /* XXX */
ret = bdrv_ioctl(bdrv, SG_IO, &io_header);
- if (ret < 0)
+ if (ret < 0 || io_header.driver_status || io_header.host_status)
return -1;
return ldl_be_p(&buf[4]);
@@ -341,7 +341,7 @@ static int get_stream_blocksize(BlockDriverState *bdrv)
io_header.timeout = 6000; /* XXX */
ret = bdrv_ioctl(bdrv, SG_IO, &io_header);
- if (ret < 0)
+ if (ret < 0 || io_header.driver_status || io_header.host_status)
return -1;
return ldl_be_p(&buf[0]) & 0xffffff;
--
1.7.6
- [Qemu-devel] [PATCH 00/10] scsi: add specialized block device passthrough, Paolo Bonzini, 2011/10/12
- [Qemu-devel] [PATCH 03/10] scsi-generic: check ioctl statuses when SG_IO succeeds,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 02/10] scsi-generic: remove scsi_req_fixup, Paolo Bonzini, 2011/10/12
- [Qemu-devel] [PATCH 05/10] scsi-disk: do not duplicate BlockDriverState member, Paolo Bonzini, 2011/10/12
- [Qemu-devel] [PATCH 07/10] scsi: make reqops const, Paolo Bonzini, 2011/10/12
- [Qemu-devel] [PATCH 01/10] scsi-generic: drop SCSIGenericState, Paolo Bonzini, 2011/10/12
- [Qemu-devel] [PATCH 06/10] scsi-disk: small clean up to INQUIRY, Paolo Bonzini, 2011/10/12
- [Qemu-devel] [PATCH 08/10] scsi: export scsi_generic_reqops, Paolo Bonzini, 2011/10/12
- [Qemu-devel] [PATCH 09/10] scsi: pass cdb to alloc_req, Paolo Bonzini, 2011/10/12
- [Qemu-devel] [PATCH 04/10] scsi-generic: look at host status, Paolo Bonzini, 2011/10/12
- [Qemu-devel] [PATCH 10/10] scsi-disk: add scsi-block for device passthrough, Paolo Bonzini, 2011/10/12