Re: [Qemu-devel] [PATCHv3] ps2: migrate ledstate

[Christophe Fergeau]

On Mon, Oct 17, 2011 at 11:25:42AM +0200, Gerd Hoffmann wrote:
> >
> >  static const VMStateDescription vmstate_ps2_common = {
> >      .name = "PS2 Common State",
> >-    .version_id = 3,
> >+    .version_id = 4,
> >      .minimum_version_id = 2,
> >      .minimum_version_id_old = 2,
> >      .fields      = (VMStateField []) {
> 
> version_id in vmstate_ps2_keyboard must be updated too.

Yeah, I somehow updated the field in the wrong struct, /me blushes and
hides. I don't think this struct version needs to be updated.

> The version update in vmstate_ps2_common might not be needed, IIRC
> the versions for stuff referenced via VMSTATE_STRUCT() isn't used
> anyway, Juan?

Ah, ok, I hoped it would help to handle migration between versions with and
without this field, I guess I was too optimistic :)

Thanks,

Christophe

pgpIEoCo6yl44.pgp
Description: PGP signature