[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/18] tcx: convert to memory API
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 18/18] tcx: convert to memory API |
Date: |
Tue, 18 Oct 2011 19:59:47 +0000 |
On Tue, Oct 18, 2011 at 7:40 PM, Avi Kivity <address@hidden> wrote:
> On 10/18/2011 08:08 PM, Blue Swirl wrote:
>>
>> > What would the API look like? accept a range, return true if any of the
>> > pages in the range are dirty?
>>
>> That would be 1:1 conversion but maybe better approach would be to
>> return the first dirty address (or zero if not found), then various
>> bitmap speedups may be available.
>
> Ah, an iterator. Yes, it would allow switching from iteration on scan
> lines to iteration on actual dirty ranges.
>
> Perhaps
>
> void memory_region_for_each_dirty_range(MemoryRegion *mr,
> target_phys_addr_t start,
> uint64_t size,
> void (*dirty)(void *opaque,
> target_phys_addr_t start, uint64_t size),
> void *opaque);
That approach could be better for the bitmap conversions, though there
is no way to exit the loop if needed and there is no status available
to the caller (for example about end of last block for bitmap
conversion).
- [Qemu-devel] [PATCH 00/18] Memory API conversions, batch 12, Avi Kivity, 2011/10/17
- [Qemu-devel] [PATCH 01/18] ppc_oldworld: convert to memory API, Avi Kivity, 2011/10/17
- [Qemu-devel] [PATCH 02/18] ppc_prep: convert to memory API, Avi Kivity, 2011/10/17
- [Qemu-devel] [PATCH 06/18] ppcr500_mpc8544ds: convert to memory API, Avi Kivity, 2011/10/17
- [Qemu-devel] [PATCH 16/18] syborg: convert to memory API, Avi Kivity, 2011/10/17
- [Qemu-devel] [PATCH 18/18] tcx: convert to memory API, Avi Kivity, 2011/10/17
[Qemu-devel] [PATCH 11/18] spapr: convert to memory API, Avi Kivity, 2011/10/17
[Qemu-devel] [PATCH 09/18] s390-virtio: convert to memory API, Avi Kivity, 2011/10/17
[Qemu-devel] [PATCH 03/18] pxa2xx: convert to memory API (part I), Avi Kivity, 2011/10/17
[Qemu-devel] [PATCH 04/18] pxa2xx: convert to memory API (part II), Avi Kivity, 2011/10/17
[Qemu-devel] [PATCH 12/18] spitz: convert to memory API, Avi Kivity, 2011/10/17
[Qemu-devel] [PATCH 08/18] realview: convert to memory API, Avi Kivity, 2011/10/17
[Qemu-devel] [PATCH 10/18] sm501: convert to memory API, Avi Kivity, 2011/10/17
[Qemu-devel] [PATCH 07/18] r2d: convert to memory API, Avi Kivity, 2011/10/17
[Qemu-devel] [PATCH 05/18] pci: simplify memory region registration, Avi Kivity, 2011/10/17
[Qemu-devel] [PATCH 15/18] sun4u: convert to memory API, Avi Kivity, 2011/10/17