[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough. |
Date: |
Wed, 19 Oct 2011 16:01:41 +0100 |
On Wed, Oct 19, 2011 at 15:48, Peter Maydell <address@hidden> wrote:
> On 19 October 2011 14:56, Anthony PERARD <address@hidden> wrote:
>> +if test "$xen_pci_passthrough" != "no"; then
>> + if test "$xen" = "yes" -a "$linux" = "yes"; then
>> + xen_pci_passthrough=yes
>> + else
>> + if test "$xen_pci_passthrough" = "yes"; then
>> + feature_not_found "Xen PCI Passthrough without Xen or not on linux"
>> + fi
>> + xen_pci_passthrough=no
>> + fi
>> +fi
>
> The -a flag to test is obsolete -- don't use it in new code.
ok, I'll just replace it by "&& test"
> This is a bit of a misuse of the feature_not_found function IMHO.
> (Also, Linux needs a capital letter.)
Yes, probably this message will be more useful:
echo "ERROR: User requested feature Xen PCI Passthrough"
echo "ERROR: but this feature require /sys from Linux"
Thanks,
--
Anthony PERARD
- [Qemu-devel] [PATCH V2 00/10] Xen PCI Passthrough, Anthony PERARD, 2011/10/19
- [Qemu-devel] [PATCH V2 02/10] Introduce HostPCIDevice to access a pci device on the host., Anthony PERARD, 2011/10/19
- [Qemu-devel] [PATCH V2 04/10] pci_ids: Add INTEL_82599_VF id., Anthony PERARD, 2011/10/19
- [Qemu-devel] [PATCH V2 03/10] pci.c: Add pci_check_bar_overlap, Anthony PERARD, 2011/10/19
- [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough., Anthony PERARD, 2011/10/19
- [Qemu-devel] [PATCH V2 05/10] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC., Anthony PERARD, 2011/10/19
- [Qemu-devel] [PATCH V2 07/10] Introduce apic-msidef.h, Anthony PERARD, 2011/10/19
- [Qemu-devel] [PATCH V2 06/10] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE, Anthony PERARD, 2011/10/19
- [Qemu-devel] [PATCH V2 08/10] Introduce Xen PCI Passthrough, qdevice (1/3), Anthony PERARD, 2011/10/19
- [Qemu-devel] [PATCH V2 10/10] Introduce Xen PCI Passthrough, MSI (3/3), Anthony PERARD, 2011/10/19
- [Qemu-devel] [PATCH V2 09/10] Introduce Xen PCI Passthrough, PCI config space helpers (2/3), Anthony PERARD, 2011/10/19