qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 35/35] scsi-disk: add scsi-block for device pass


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH 35/35] scsi-disk: add scsi-block for device passthrough
Date: Mon, 24 Oct 2011 17:38:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0

Am 24.10.2011 17:28, schrieb Paolo Bonzini:
> On 10/24/2011 05:28 PM, Kevin Wolf wrote:
>>> scsi-block is a new device that supports device passthrough of Linux
>>>>  block devices (i.e. /dev/sda, not /dev/sg0).  It uses SG_IO for commands
>>>>  other than I/O commands, and regular AIO read/writes for I/O commands.
>>>>  Besides being simpler to configure (no mapping required to scsi-generic
>>>>  device names), this removes the need for a large bounce buffer and,
>>>>  in the future, will get scatter/gather support for free from scsi-disk.
>>>>
>>>>  Signed-off-by: Paolo Bonzini<address@hidden>
>>
>> This doesn't seem to use much of scsi-disk, so what about exporting
>> &scsi_disk_reqops and adding a separate file scsi-block.c? Would make
>> things a bit more symmetrical between scsi-disk and scsi-generic.
>>
>> Or will future patches add code that depends on internal interfaces of
>> scsi-disk?
> 
> It already uses some internal interfaces: scsi_initfn, scsi_disk_reset, 
> scsi_destroy, sizeof(SCSIDiskState).

Right... I don't like it much in scsi-disk.c, but what can you do.
Exporting everything wouldn't be nicer.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]