[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/25] vmstate: make all architectures export a
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 03/25] vmstate: make all architectures export a way to migrate cpu's |
Date: |
Tue, 25 Oct 2011 17:50:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
Andreas Färber <address@hidden> wrote:
> Am 25.10.2011 16:00, schrieb Juan Quintela:
>> This makes several changes:
>> - exports VMStateDescription vmstate_cpu non-static.
>> - makes sure that every cpu has a vmstate_cpu or cpu_save/load defined
>> - for the architecture that had nothing, it just register the cpu as
>> unmigratable.
>> - Depending on CPU_SAVE_VERSION we register old/new migration style
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>
> I like that move in general.
>
>> diff --git a/target-m68k/machine.c b/target-m68k/machine.c
>> index e69de29..86b6fe9 100644
>> --- a/target-m68k/machine.c
>> +++ b/target-m68k/machine.c
>> @@ -0,0 +1,10 @@
>> +
>> +#include "hw/hw.h"
>> +
>> +/* To make this architecture migratable, we need to define cpu state
>> + here. Other things need to be done elsewhere */
>> +
>> +const VMStateDescription vmstate_cpu = {
>> + .name = "cpu",
>> + .unmigratable = 1,
>> +};
>
> Here ...
>
>> diff --git a/target-sh4/machine.c b/target-sh4/machine.c
>> index e69de29..86b6fe9 100644
>> --- a/target-sh4/machine.c
>> +++ b/target-sh4/machine.c
>> @@ -0,0 +1,10 @@
>> +
>> +#include "hw/hw.h"
>> +
>> +/* To make this architecture migratable, we need to define cpu state
>> + here. Other things need to be done elsewhere */
>> +
>> +const VMStateDescription vmstate_cpu = {
>> + .name = "cpu",
>> + .unmigratable = 1,
>> +};
>
> ... and here you sort-of create new files (empty before) without a
> license header. The contents is trivial right now, but it would get a
> case for the Wiki trying to figure out what license to put on other
> people's code.
None of target-*/machine.c files have a license line. I can put the
normal boilerplate on them, but I have just transformed them, So .. who
should I put as copyright owner? Puting me is (at least) a bit
presumptuous, if not just plain false O:-)
Later, Juan.
- [Qemu-devel] [PATCH 00/25] VMState port of all cpus, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 02/25] vmstate: Simplify test for CPU_SAVE_VERSION, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 01/25] vmstate: Fix VMSTATE_VARRAY_UINT32, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 04/25] vmstate: unicore32 don't support cpu migration, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 05/25] vmstate: use new cpu style for x86, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 07/25] vmstate: make microblaze cpus not migrateable, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 06/25] vmstate: use new style for lm32 cpus, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 03/25] vmstate: make all architectures export a way to migrate cpu's, Juan Quintela, 2011/10/25
- Re: [Qemu-devel] [PATCH 03/25] vmstate: make all architectures export a way to migrate cpu's, Max Filippov, 2011/10/25
- Re: [Qemu-devel] [PATCH 03/25] vmstate: make all architectures export a way to migrate cpu's, Richard Henderson, 2011/10/25
- Re: [Qemu-devel] [PATCH 03/25] vmstate: make all architectures export a way to migrate cpu's, Michael Walle, 2011/10/25
- [Qemu-devel] [PATCH 08/25] vmstate: port cris cpu to vmstate, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 09/25] vmstate: machine.c is only compiled for !CONFIG_USER_ONLY, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 11/25] vmstate: introduce float64 arrays, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 10/25] vmstate: introduce float32 arrays, Juan Quintela, 2011/10/25
- [Qemu-devel] [PATCH 17/25] vmstate: make incompatible change for sparc, Juan Quintela, 2011/10/25