Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

[Andreas Färber]

Am 26.10.2011 18:02, schrieb Jan Kiszka:
> On 2011-10-26 17:18, Peter Maydell wrote:
>> On 26 October 2011 16:13, Jan Kiszka <address@hidden> wrote:
>>> My point is that it is fine to use for per-vcpu variables because:
>>>  - they are single-threaded in TCG mode
>>>  - they are multi-threaded in KVM mode, but that's only affecting Linux
>>>   hosts for which this TLS wrapper is already usable
>>
>> Oh, I see. Feel free to suggest reworded comment text :-)
> 
> /* Dummy implementations -- we can get away with this because
>  *  - we confine the use to per-VCPU variables
>  *  - only linux-user supports multiple VCPU threads
>  *  - TCG system mode is single-threaded regarding VCPUs

>  *  - KVM system mode is multi-threaded but limited to Linux

There was a port of KVM to illumos-derived SmartOS. But I don't see an
easy way to error out on non-Linux KVM hosts without breaking TCG, too.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg