[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 13/55] block: fix qcow2_co_flush deadlock
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 13/55] block: fix qcow2_co_flush deadlock |
Date: |
Mon, 31 Oct 2011 14:29:48 +0100 |
From: Dong Xu Wang <address@hidden>
If qcow2_cache_flush failed, s->lock will not be unlock.
Signed-off-by: Dong Xu Wang <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/qcow2.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index a181932..ef057d3 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1113,11 +1113,13 @@ static int qcow2_co_flush(BlockDriverState *bs)
qemu_co_mutex_lock(&s->lock);
ret = qcow2_cache_flush(bs, s->l2_table_cache);
if (ret < 0) {
+ qemu_co_mutex_unlock(&s->lock);
return ret;
}
ret = qcow2_cache_flush(bs, s->refcount_block_cache);
if (ret < 0) {
+ qemu_co_mutex_unlock(&s->lock);
return ret;
}
qemu_co_mutex_unlock(&s->lock);
--
1.7.6.4
- [Qemu-devel] [PATCH 02/55] Documentation: Add iSCSI section, (continued)
- [Qemu-devel] [PATCH 02/55] Documentation: Add iSCSI section, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 01/55] iSCSI block driver, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 03/55] Teach block/vdi about "discarded" (no longer allocated) blocks, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 04/55] qcow2: fix some errors and typo in qcow2.txt, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 05/55] block: Remove dead code, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 06/55] block: Fix bdrv_open use after free, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 07/55] qcow: Fix bdrv_write_compressed error handling, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 09/55] vmdk: Fix use of uninitialised value, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 08/55] ide: Fix off-by-one error in array index check, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 12/55] Documentation: Describe NBD URL syntax, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 13/55] block: fix qcow2_co_flush deadlock,
Kevin Wolf <=
- [Qemu-devel] [PATCH 10/55] vmdk: Improve error handling, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 11/55] vmdk: Fix possible segfaults, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 14/55] qemu-io: delete bs instead of leaking it, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 15/55] block: set bs->read_only before .bdrv_open(), Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 17/55] Documentation: Add syntax for using sheepdog devices, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 16/55] block: reinitialize across bdrv_close()/bdrv_open(), Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 18/55] scsi: pass correct sense code for ENOMEDIUM, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 35/55] scsi: allow arbitrary LUNs, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 33/55] scsi: remove devs array from SCSIBus, Kevin Wolf, 2011/10/31
- [Qemu-devel] [PATCH 38/55] scsi-disk: fix retrying a flush, Kevin Wolf, 2011/10/31