[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU sour
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree |
Date: |
Tue, 08 Nov 2011 17:00:01 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
陳韋任 <address@hidden> writes:
> On Tue, Nov 08, 2011 at 04:07:12PM +0100, Markus Armbruster wrote:
>> 陳韋任 <address@hidden> writes:
>>
>> >> Please thread together your patches so that the parts appear as replies
>> >> to the cover letter. git-send-email should do that by default.
>> >>
>> >> Why? Disconnected parts can easily get separated in the list. When
>> >> that happens, your reviewers need to hunt for parts. They may choose to
>> >> review something else instead. Can't blame them; reviewing is more
>> >> productive than hunting for parts.
>> >
>> > Sorry about that. Should I re-sent this series?
>>
>> Try that if you don't get reviews ;) Else just get it right with your
>> next patch series.
>
> O.K.. Just want to make sure. What you said "thread together your
> patches" has something to do with "sendemail.chainreplyto"? I found
> I sent this series one by one, i.e., `git send-email 000#.patch`.
> I think I should sent them as a whole, i.e., `git send-email *`. But
> I am not sure "sendemail.chainreplyto" matters or not.
Max already explaind chainreplyto. I agree with him that chainreplyto
off is preferable.
But what you're after is --thread / sendemail.thread. See man
git-send-email for details. The default is --thread, which does the
threading, provided you send all parts at once.