[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a targ
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target |
Date: |
Tue, 08 Nov 2011 22:49:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 |
Am 08.11.2011 18:08, schrieb 陳韋任:
>> Have you build this? without this files qemu is not going to work.
>> Perhaps the naming is wrong, and we should change common-obj to
>> something else, but it is still needed to get things working as
>> expected.
>
> I found the line below in Makefile,
>
> $(filter %-softmmu,$(SUBDIR_RULES)): $(trace-obj-y) $(common-obj-y)
> subdir-libdis
>
> I guess you ran into trouble while building *-softmmu? I think we can
> just remove "libqemu_common.a:" from the comment of common-obj-y and
> leave the rest part alone.
Yes, please. I believe I'm the one to blame, I replaced the .a target
with these lists of .o files to fix the build on OpenSolaris after
constructors was introduced.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg