Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

[Andreas Färber]

Am 10.11.2011 07:33, schrieb Stefan Weil:
> Am 10.11.2011 00:45, schrieb Alexander Graf:
>>
>> On 09.11.2011, at 13:47, Luiz Capitulino wrote:
>>
>>> On Wed, 09 Nov 2011 11:27:22 +0100
>>> Andreas Färber <address@hidden> wrote:
>>>
>>>> Am 09.11.2011 06:58, schrieb Stefan Weil:
>>>>> No. Simply remove */qmp-commands.h. They are relicts from previous
>>>>> builds.
>>>>
>>>> If make clean didn't help, please patch that instead then.
>>>
>>> So, did it fix the problem for you Alex?
>>
>> Yup :). However, if I run into this other users / developers will too.
>>
>>
>> Alex
> 
> Hi Alex,
> 
> there is a rather simple solution for this kind of problems:
> don't run make in your source tree.
> 
> QEMU supports out-of-tree builds since several years now.
> So this helps:
> 
> # Run the following commands from QEMU's source root directory.
> rm -rf bin && mkdir bin && cd bin && ../configure && make
> 
> This also allows several build directories with different configurations.
> I use for example different trees for fast builds without compiler
> optimization and full debugging and for production builds.
> By the way: CFLAGS=-g is also very useful for build bots!
> 
> bin/debug  # directory configured with --enable-debug and CFLAGS=-g
> bin/ndebug # directory with default settings and compiler optimization

Stefan and Anthony, I usually do build out-of-tree but that suggestion
still ignores the issue that cleaning the build, whether in-tree or
out-of-tree, before a pull defeats the whole purpose of dependency-based
conditional compilation and wastes a lot of time.

Removing these stale generated files should've been something Luis'
patch should've been doing IMO, then it's easily reviewable and
testable; now we can still verify by doing a checkout and build of the
predecessor commit and HEAD, and pulling that in through qemu-trivial
doesn't cost you, Anthony, a lot of time if you don't see our point. :)

Hell, we still clean up dyngen files in Makefile so let's not be too
lazy to clean up things that actually do break the build for core
contributors!

If Alex doesn't beat me I'll look into it next time I have a
long-running test case.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg