[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too |
Date: |
Thu, 10 Nov 2011 10:36:26 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Nov 10, 2011 at 04:21:46PM +0800, Dong Xu Wang wrote:
> > if (s->fd != -1) {
> > - close(s->fd);
> > + if (close(s->fd) < 0)
> > + r = -errno;
> Braces {} are necessary, or checkpatch.pl will give warnings, also in
> other patches in your series.
>
> No mistake, just reminder. :)
I will send v3 with the coding style fixed (I was supposed to fix this
before submitting v2 but I forgot). Thanks!
--
Eduardo
- [Qemu-devel] [PATCH 00/10] qemu_fclose() error handling fixes (v2), Eduardo Habkost, 2011/11/09
- [Qemu-devel] [PATCH 01/10] savevm: use qemu_file_set_error() instead of setting last_error directly, Eduardo Habkost, 2011/11/09
- [Qemu-devel] [PATCH 02/10] QEMUFileCloseFunc: add return value documentation (v2), Eduardo Habkost, 2011/11/09
- [Qemu-devel] [PATCH 08/10] exec_close(): return -errno on errors, Eduardo Habkost, 2011/11/09
- [Qemu-devel] [PATCH 10/10] unix_close(): check for close() errors too, Eduardo Habkost, 2011/11/09
- [Qemu-devel] [PATCH 03/10] exec_close(): accept any negative value as qemu_fclose() error, Eduardo Habkost, 2011/11/09
- [Qemu-devel] [PATCH 06/10] stdio_pclose: return -errno on error (v2), Eduardo Habkost, 2011/11/09
- [Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too, Eduardo Habkost, 2011/11/09
- [Qemu-devel] [PATCH 04/10] migrate_fd_cleanup: accept any negative qemu_fclose() value as error, Eduardo Habkost, 2011/11/09
- [Qemu-devel] [PATCH 05/10] qemu_fclose: return last_error if set (v2), Eduardo Habkost, 2011/11/09
- [Qemu-devel] [PATCH 07/10] stdio_fclose: return -errno on errors, Eduardo Habkost, 2011/11/09
- Re: [Qemu-devel] [PATCH 00/10] qemu_fclose() error handling fixes (v2), Anthony Liguori, 2011/11/09
- Re: [Qemu-devel] [PATCH 00/10] qemu_fclose() error handling fixes (v2), Eduardo Habkost, 2011/11/10