[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] qcow2: Return real error code in qcow2_writ
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] qcow2: Return real error code in qcow2_write_snapshots |
Date: |
Fri, 18 Nov 2011 14:14:56 +0000 |
On Thu, Nov 17, 2011 at 3:13 PM, Kevin Wolf <address@hidden> wrote:
> - /* update the various header fields */
> + /*
> + * Update the header to point to the new snapshot table. This requires
> the
> + * new table and its refcounts to be stable on disk.
> + *
> + * FIXME This should be done with a single write
The nb_snapshots and snapshots_offset writes can be easily combined
since the fields are adjacent in QcowHeader. I think it's worth
changing the code to do it in this patch series instead of leaving a
FIXME comment.
Stefan
- [Qemu-devel] [PATCH 0/8] qcow2: Fix error paths for internal snapshots, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 1/8] qcow2: Return real error code in qcow2_read_snapshots, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 4/8] qcow2: Rework qcow2_snapshot_create error handling, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 3/8] qcow2: Cleanups and memleak fix in qcow2_snapshot_create, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 7/8] qcow2: Fix order in qcow2_snapshot_delete, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 6/8] qcow2: Fix order of refcount updates in qcow2_snapshot_goto, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 2/8] qcow2: Return real error code in qcow2_write_snapshots, Kevin Wolf, 2011/11/17
- Re: [Qemu-devel] [PATCH 2/8] qcow2: Return real error code in qcow2_write_snapshots,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 8/8] qcow2: Fix error path in qcow2_snapshot_load_tmp, Kevin Wolf, 2011/11/17
- [Qemu-devel] [PATCH 5/8] qcow2: Return real error in qcow2_snapshot_goto, Kevin Wolf, 2011/11/17
- Re: [Qemu-devel] [PATCH 0/8] qcow2: Fix error paths for internal snapshots, Stefan Hajnoczi, 2011/11/18