[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/6] vl: Tighten parsing of -m argument
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 3/6] vl: Tighten parsing of -m argument |
Date: |
Tue, 22 Nov 2011 09:46:03 +0100 |
strtosz_suffix() fails unless the size is followed by 0, whitespace or
','. Useless here, because we need to fail for any junk following the
size, even if it starts with whitespace or ','. Check manually.
Things like "-m 1024," are now caught.
Signed-off-by: Markus Armbruster <address@hidden>
---
vl.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index b9146cf..a50842b 100644
--- a/vl.c
+++ b/vl.c
@@ -2535,9 +2535,10 @@ int main(int argc, char **argv, char **envp)
break;
case QEMU_OPTION_m: {
int64_t value;
+ char *end;
- value = strtosz(optarg, NULL);
- if (value < 0) {
+ value = strtosz(optarg, &end);
+ if (value < 0 || *end) {
fprintf(stderr, "qemu: invalid ram size: %s\n", optarg);
exit(1);
}
--
1.7.6.4
- [Qemu-devel] [PATCH 0/6] Fix strtosz users, clean up its implementation, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 5/6] qemu-img: Tighten parsing of size arguments, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 2/6] vl: Tighten parsing of -numa's parameter mem, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 1/6] cutils: Drop broken support for zero strtosz default_suffix, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 6/6] cutils: Make strtosz & friends leave follow set to callers, Markus Armbruster, 2011/11/22
- [Qemu-devel] [PATCH 3/6] vl: Tighten parsing of -m argument,
Markus Armbruster <=
- [Qemu-devel] [PATCH 4/6] x86/cpuid: Tighten parsing of tsc_freq=FREQ, Markus Armbruster, 2011/11/22
- Re: [Qemu-devel] [PATCH 0/6] Fix strtosz users, clean up its implementation, Anthony Liguori, 2011/11/28