|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH V2] Add -f option to qemu-nbd |
| Date: | Wed, 23 Nov 2011 08:24:05 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 |
On 11/23/2011 07:51 AM, Chun Yan Liu wrote:
According to above code logic, if lock in an early place is not accepted, then removing CLEAR_SOCK in nbd_init phase can also solve problem. In fact, if cleanup work done well, I think that ioctl is not needed. Any comments?
I think you're right. In addition, SET_BLKSIZE and SET_SIZE should not be sent unless SET_SOCK succeeds.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |