[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 07/11] bonito: convert north bridge register
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH v3 07/11] bonito: convert north bridge register mapping to memory API |
Date: |
Thu, 24 Nov 2011 10:40:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 11/23/2011 01:03 AM, Peter Maydell wrote:
> 2011/11/22 Benoît Canet <address@hidden>:
> > static int bonito_initfn(PCIDevice *dev)
> > {
> > PCIBonitoState *s = DO_UPCAST(PCIBonitoState, dev, dev);
> > + SysBusDevice *sysbus = sysbus_from_qdev(&dev->qdev);
>
> This looks odd. The device here is a PCIBonitoState, which
> is-a PCIDevice, which is-a DeviceState. It's not a SysBusDevice
> and merely casting doesn't make it one.
>
> I'm not sure what should be being done here, but I'm pretty
> sure this won't work...
s->pcihost.busdev gives you a SysBusDevice (and
s->pcihost.confmem/datamem gives you a few MemoryRegions that you need
later in bonito_initfn.
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH v3 01/11] mcf5206: convert to memory API, (continued)
- [Qemu-devel] [PATCH v3 01/11] mcf5206: convert to memory API, Benoît Canet, 2011/11/22
- [Qemu-devel] [PATCH v3 02/11] mcf_uart: convert to memory API, Benoît Canet, 2011/11/22
- [Qemu-devel] [PATCH v3 04/11] mcf_intc: convert to memory API, Benoît Canet, 2011/11/22
- [Qemu-devel] [PATCH v3 03/11] mcf_fec: convert to memory API, Benoît Canet, 2011/11/22
- [Qemu-devel] [PATCH v3 05/11] lm32_uart: convert to memory API, Benoît Canet, 2011/11/22
- [Qemu-devel] [PATCH v3 06/11] lm32_sys: convert to memory API, Benoît Canet, 2011/11/22
- [Qemu-devel] [PATCH v3 07/11] bonito: convert north bridge register mapping to memory API, Benoît Canet, 2011/11/22
[Qemu-devel] [PATCH v3 09/11] bonito: convert south bridge pci config to memory API, Benoît Canet, 2011/11/22
[Qemu-devel] [PATCH v3 11/11] bonito: convert cop to memory API, Benoît Canet, 2011/11/22
[Qemu-devel] [PATCH v3 08/11] bonito: convert north bridge pci config to memory API, Benoît Canet, 2011/11/22
[Qemu-devel] [PATCH v3 10/11] bonito: convert ldma to memory API, Benoît Canet, 2011/11/22