[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile a
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board |
Date: |
Thu, 24 Nov 2011 21:52:03 +0000 |
On 24 November 2011 21:46, Andreas Färber <address@hidden> wrote:
> Am 24.11.2011 22:31, schrieb Peter Maydell:
>> On 24 November 2011 20:19, Andreas Färber <address@hidden> wrote:
>>> Am 24.11.2011 20:41, schrieb Peter Maydell:
>>>> On 22 November 2011 04:34, Peter Chubb <address@hidden> wrote:
>>>>> +obj-arm-y += imx_serial.o imx_timer.o imx_avic.o
>>>>> +obj-arm-y += kzm.o
>>>>
>>>> It would be better to add the devices to the makefile in their
>>>> corresponding patches, I think. (Don't feel too strongly about that
>>>> though so somebody might overrule me.)
>>>
>>> Well, I do: Without adding them to the Makefile they don't get
>>> compile-tested. (I prefer convincing over ruling though.)
>>
>> Er, which way are you arguing? If patch 1 adds hw/foo.c and also
>> adds foo.o to the makefile rune then it gets compile tested...
>
> I'm asking for Peter C. to revise the series, please.
OK, in that case we agree.
-- PMM
- Re: [Qemu-devel] [PATCH V2 2/4] imx.31 and KZM board support: Timer support, (continued)
- Re: [Qemu-devel] [PATCH V2 3/4] imx.31 and KZM board support: interrupt controller, Peter Chubb, 2011/11/21
- Re: [Qemu-devel] [PATCH V2 3/4] imx.31 and KZM board support: interrupt controller, Peter Maydell, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Chubb, 2011/11/21
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Maydell, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Andreas Färber, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Maydell, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Andreas Färber, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Peter Chubb, 2011/11/22
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Andreas Färber, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Peter Chubb, 2011/11/26
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Peter Maydell, 2011/11/26
Re: [Qemu-devel] [PATCH] imx.31 and KZM board support, Juan Quintela, 2011/11/22