qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] Support for UDP unicast network backend


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v2] Support for UDP unicast network backend
Date: Mon, 28 Nov 2011 11:39:53 +0000

On Fri, Nov 25, 2011 at 12:49 PM, Benjamin <address@hidden> wrote:
> +    fd = qemu_socket(PF_INET, SOCK_DGRAM, 0);
> +    if (fd < 0) {
> +        perror("socket(PF_INET, SOCK_DGRAM)");
> +        return -1;
> +    }
> +    val = 1;
> +    ret = setsockopt(fd, SOL_SOCKET, SO_REUSEADDR,
> +                   (const char *)&val, sizeof(val));
> +    if (ret < 0) {
> +        perror("setsockopt(SOL_SOCKET, SO_REUSEADDR)");

Please avoid leaking the file descriptor on error:
closesocket(fd);

Since existing code also does this it may be more appropriate to send
a follow-up patch that cleans up all of net/socket.c.

Reviewed-by: Stefan Hajnoczi <address@hidden>

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]