On Wed, 30 Nov 2011, Stefan Hajnoczi wrote:
On Tue, Nov 29, 2011 at 10:47 PM, Michael Roth
<address@hidden> wrote:
Generally $(BUILD_DIR) == $(CURDIR), but that isn't necessarilly the
case, so use $(BUILD_DIR)/qapi-generated for generated files to
avoid potentionally sticking generating files in odd places outside
the build's include paths.
---
� Makefile | � � 2 +-
� 1 files changed, 1 insertions(+), 1 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
Not applied to trivial tree yet. I want to let Stefano, Stefan Weil,
or Anthony take a look too since we were all discussing these changes
yesterday.
While I think that the change is correct (certainly better than the
original patch), unfortunately still doesn't solve the problem
entirely.
Steps to repro, assuming "qemu" is the source tree and "temp" is the
empty build directory:
- cd qemu; ./configure; make
- cd ../temp; ./configure --source-path=../qemu; make
Result:
Makefile:9: config-devices.mak: No such file or directory
In order to fix the issue, we need to make sure that config-devices.mak
is relative to $(BUILD_DIR) in the Makefile.
Signed-off-by: Stefano Stabellini <address@hidden>
diff --git a/Makefile b/Makefile