On 12/01/2011 03:47 PM, Anthony Liguori wrote:
What if it's called with the output visitor? (warning: confusing
convention).
The reason there's a single Visitor type that works for both input and
output visitors is to make it so you can write a single visit function
that works for input and output. This works very well for most cases
(in fact, QAPI makes heavy use of it).
That said, I'm starting to feel like there should be a separate input
and output visitor interface. It would make a number of things (like
visiting lists) significantly simpler.
Perhaps. But that's independent of the issue here. No matter how many
visitors you have, you never change a gchar in a string in place, you
always allocate a new string (or you can't change the string length).
So the type needs to be const gchar **, not gchar **.