qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as new st


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as new style properties
Date: Thu, 01 Dec 2011 16:51:18 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111104 Red Hat/3.1.16-2.el6_1 Thunderbird/3.1.16

  Hi,

> +    for (prop = dev->info->props; prop && prop->name; prop++) {
> +        qdev_property_add_legacy(dev, prop, NULL);
> +    }

bus properties?

> +static void qdev_get_legacy_property(DeviceState *dev, Visitor *v, void 
> *opaque,
> +                                     const char *name, Error **errp)
> +{
> +    Property *prop = opaque;
> +
> +    if (prop->info->print) {
> +        char buffer[1024];
> +        char *ptr = buffer;
> +
> +        prop->info->print(dev, prop, buffer, sizeof(buffer));
> +        visit_type_str(v, &ptr, name, errp);

I think you can look at prop->info->type here and do something more
clever at least for the bool + integer properties.

cheers,
  Gerd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]