Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

[Stefan Weil]

Am 07.12.2011 20:06, schrieb andrzej zaborowski:
> On 7 December 2011 19:57, Stefan Weil <address@hidden> wrote:
> > Am 07.12.2011 08:47, schrieb Andrzej Zaborowski:
> > > +#ifdef NCURSES_VERSION
> > > +# if NCURSES_VERSION_PATCH < 20040117
> > > +# error Old ncurses contain dangerous typedefs, break qemu build 
> > > (and are
> > > old)
> > > +# endif
> > > +#endif
> > > int main(void) { resize_term(0, 0); return curses_version(); }
> > > EOF
> > > for curses_lib in $curses_list; do
> >
> >
> > Is NCURSES_VERSION_PATCH always defined when NCURSES_VERSION is?
>
> I'm not sure, will try to find out. If it isn't then we should check
> that NCURSES_VERSION_MINOR < 4 perhaps.
>
> The intent of checking defined(NCURSES_VERSION) is to detect ncurses
> because qemu should also build with other implementations of curses
> (in theory).
>
> Cheers

Yes, that's right. W32 for example supports pdcurses. So the check
might look like this:

#if defined(NCURSES_VERSION_PATCH) && NCURSES_VERSION_PATCH < 20040117
# error Old ncurses contain dangerous typedefs, break qemu build (and 
are old)
#endif

Cheers,
Stefan